Re: SIGPIPE handling

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Manfred Spraul <manfred(at)colorfullife(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: SIGPIPE handling
Date: 2003-11-16 18:30:24
Message-ID: 29350.1069007424@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Manfred Spraul <manfred(at)colorfullife(dot)com> writes:
> + extern void PQsetsighandling(int internal_sigign);

These sorts of things are commonly designed so that the set() operation
incidentally returns the previous setting. I'm not sure if anyone would
care, but it's only a couple more lines of code to make that happen, so
I'd suggest doing so just in case.

Otherwise I think this is a good patch. The documentation could use a
little more wordsmithing, perhaps.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Jan Wieck 2003-11-16 20:00:24 Re: [PATCHES] SRA Win32 sync() code
Previous Message Tom Lane 2003-11-16 18:21:38 Re: [PATCHES] SRA Win32 sync() code