Re: ts_locale.c: why no t_isalnum() test?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: ts_locale.c: why no t_isalnum() test?
Date: 2022-10-19 22:39:32
Message-ID: 2933409.1666219172@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Corey Huinker <corey(dot)huinker(at)gmail(dot)com> writes:
> I see this is already committed, but I'm curious, why do t_isalpha and
> t_isdigit have the pair of /* TODO */ comments? This unfinished business
> isn't explained anywhere in the file.

We really ought to be consulting the locale/collation passed to
the SQL-level operator or function that's calling these things,
instead of hard-wiring the database default. Passing that down
would take a large and boring patch, but somebody ought to tackle
it someday.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2022-10-19 23:24:25 Re: refactor ownercheck and aclcheck functions
Previous Message Corey Huinker 2022-10-19 22:12:47 Re: ts_locale.c: why no t_isalnum() test?