Re: Use of $(THREAD_CFLAGS) in CPPFLAGS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use of $(THREAD_CFLAGS) in CPPFLAGS
Date: 2003-09-27 02:48:37
Message-ID: 293.1064630917@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I just noticed that libpq/ecpg use $(THREAD_CFLAGS) as part of CPPFLAGS.
> Is that correct? Should it be added to CFLAGS instead?

I was just noticing that today. THREAD_CFLAGS typically includes -D
flags, and as such it *must* be added to CPPFLAGS --- it'd be incorrect
to add it to CFLAGS. Possibly we should rename THREAD_CFLAGS to
THREAD_CPPFLAGS. I'm not sure that we have any platforms for which it
would be useful to invent both THREAD_CPPFLAGS and THREAD_CFLAGS.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Brown 2003-09-27 02:48:40 Re: invalid tid errors in latest 7.3.4 stable.
Previous Message Tom Lane 2003-09-27 02:44:43 Re: Separate shared_buffer management process