From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Re: [BUGS] WIN32 Non Blocking |
Date: | 2001-08-04 17:11:44 |
Message-ID: | 29296.996945104@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-interfaces pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Do we have a fix for this? It is a WIN32/libpq/multibyte problem.
AFAIK it's all fixed (barring new bug reports ;-)). The main problems
were (a) win32.mak hadn't gotten updated when we changed the set of
backend source files that are included into libpq for MULTIBYTE;
(b) win32.mak failed to define FRONTEND, (c) someone had incorrectly
added
#ifndef WIN32
int optval;
#else
char optval;
#endif
upon noting that his Windows compiler griped about
if (getsockopt(conn->sock, SOL_SOCKET, SO_ERROR,
&optval, &optlen) == -1)
instead of realizing that the correct fix is
if (getsockopt(conn->sock, SOL_SOCKET, SO_ERROR,
(char *) &optval, &optlen) == -1)
(a) is new in 7.1 but the other bugs go back at least to 7.0.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-08-04 17:18:00 | Re: HELP! BUG? pg_dump mucks up grant/revoke |
Previous Message | Tom Lane | 2001-08-04 16:28:12 | Re: HELP! BUG? pg_dump mucks up grant/revoke |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-08-04 17:18:36 | Re: Re: [BUGS] WIN32 Non Blocking |
Previous Message | Dave Page | 2001-08-04 11:56:43 | RE: ODBC driver installation error |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-08-04 17:18:36 | Re: Re: [BUGS] WIN32 Non Blocking |
Previous Message | Tom Lane | 2001-08-04 16:55:24 | Re: Patch for Improved Syntax Error Reporting |