| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: pgsql: psql: add an optional execution-count limit to \watch. |
| Date: | 2023-04-07 14:00:23 |
| Message-ID: | 2929174.1680876023@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> On Thu, Apr 6, 2023 at 8:18 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> psql: add an optional execution-count limit to \watch.
> This commit makes tests fail for me. psql parses 'i' option of
> '\watch' using locale-aware strtod(), but 001_basic.pl uses hard-coded
> decimal separator.
Huh, yeah, I see it too if I set LANG=ru_RU.utf8 before running psql's
TAP tests. It seems unfortunate that none of the buildfarm has noticed
this. I guess all the TAP tests are run under C locale?
> The proposed fix is attached.
LGTM, will push in a bit (unless you want to?)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2023-04-07 14:06:34 | Re: pgsql: psql: add an optional execution-count limit to \watch. |
| Previous Message | Alexander Korotkov | 2023-04-07 12:04:00 | Re: pgsql: psql: add an optional execution-count limit to \watch. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2023-04-07 14:06:34 | Re: pgsql: psql: add an optional execution-count limit to \watch. |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-04-07 13:59:58 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |