| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Introduce WaitEventSet API. |
| Date: | 2016-03-21 19:19:22 |
| Message-ID: | 29187.1458587962@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> Introduce WaitEventSet API.
Buildfarm member gaur has a quibble with this patch:
latch.c:1095: warning: `WaitEventSetWaitBlock' declared inline after being called
Please rearrange the file so that the inline function definitions appear
first. Also, why is it that only three of the four variants are marked
"inline"?
Actually ... given that it's static and called in exactly one place,
I would think that any compiler capable of inlining it would do so
whether asked to or not. So another solution is just to get rid
of all the "inline" specifiers and let the compiler do its job.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-03-21 22:34:29 | pgsql: Allow the delay in psql's \watch command to be a fractional seco |
| Previous Message | Tom Lane | 2016-03-21 16:00:18 | pgsql: Clean up some Coverity complaints about commit 0bf3ae88af330496. |