Re: pgsql/src/backend/commands sequence.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Vadim B(dot) Mikheev - CVS" <vadim(at)hub(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/backend/commands sequence.c
Date: 2001-04-03 22:38:02
Message-ID: 29181.986337482@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

"Vadim B. Mikheev - CVS" <vadim(at)hub(dot)org> writes:
> Modified files:
> src/backend/commands: sequence.c

> Log message:
> Log sequence creation (to initialize magic number on recovery).

This change has at least one serious bug: you access and update the
sequence's buffer after you have done ReleaseBuffer. Shouldn't the
ReleaseBuffer call be after the critical section?

Also, why'd you replace WriteBuffer with ReleaseBuffer anyway? Doesn't
the buffer need to get marked dirty here??

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Philip Warner - CVS 2001-04-04 06:47:30 pgsql/src/bin/pg_dump pg_backup_archiver.h pg_ ...
Previous Message Vadim B. Mikheev - CVS 2001-04-03 21:58:00 pgsql/src/backend/commands sequence.c