| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>, Jason Petersen <jason(at)citusdata(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] Concurrent ALTER SEQUENCE RESTART Regression |
| Date: | 2017-05-10 14:29:02 |
| Message-ID: | 2913.1494426542@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
> On 10/05/17 07:09, Peter Eisentraut wrote:
>> I think the correct fix is to have nextval() and ALTER SEQUENCE use
>> sensible lock levels so that they block each other. Since
>> nextval() currently uses AccessShareLock, the suggestion was for
>> ALTER SEQUENCE to therefore use AccessExclusiveLock. But I think a
>> better idea would be for nextval() to use RowExclusiveLock
>> (analogous to UPDATE) and ALTER SEQUENCE to use
>> ShareRowExclusiveLock, which would also satisfy issue #1.
> When I proposed this upstream, Andres raised concern about performance
> of nextval() if we do this, did you try to run any benchmark on this?
As long as it doesn't block, the change in lock strength doesn't actually
make any speed difference does it?
If we were taking AccessExclusiveLock somewhere, I'd be worried about
the cost of WAL-logging those; but this proposal does not include any.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-05-10 16:24:50 | Re: Concurrent ALTER SEQUENCE RESTART Regression |
| Previous Message | Petr Jelinek | 2017-05-10 13:52:14 | Re: Concurrent ALTER SEQUENCE RESTART Regression |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chapman Flack | 2017-05-10 14:34:58 | Re: idea: custom log_line_prefix components besides application_name |
| Previous Message | Petr Jelinek | 2017-05-10 13:56:49 | Re: 'nocopy data' option is set in SUBSCRIPTION but still data is getting migrated |