Re: Regression tests fail with musl libc because libpq.so can't be loaded

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, walther(at)technowledgy(dot)de, Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: 2024-03-26 15:45:55
Message-ID: 2901434.1711467955@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 26.03.24 00:43, Tom Lane wrote:
>> I looked at the musl source code you identified and confirmed that
>> only the LD_LIBRARY_PATH string is remembered in a static variable;
>> LD_PRELOAD is only accessed locally in that initialization function.
>> So we only need to do the attached. (I failed to resist the
>> temptation to rewrite the comments.)

> Yeah, I was more looking for a comment for posterity for *why* we need
> to preserve this variable in particular. The updated comment looks
> reasonable.

OK, pushed after a bit more comment-fiddling.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Euler Taveira 2024-03-26 18:18:49 Re: BUG #18402: Attaching a new partition doesn't reuse the prebuilt index on said partition
Previous Message Tom Lane 2024-03-26 14:35:43 Re: Regression tests fail with musl libc because libpq.so can't be loaded

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-03-26 16:13:43 Re: pgsql: Track last_inactive_time in pg_replication_slots.
Previous Message Alvaro Herrera 2024-03-26 15:39:55 Re: pgsql: Track last_inactive_time in pg_replication_slots.