Re: Online enabling of checksums

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Banck <michael(dot)banck(at)credativ(dot)de>
Subject: Re: Online enabling of checksums
Date: 2018-02-27 16:51:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi, Magus!

> 25 февр. 2018 г., в 21:17, Magnus Hagander <magnus(at)hagander(dot)net> написал(а):
> PFA an updated patch that adds this, and also fixes the problem in pg_verify_checksums spotted by Michael Banck.

I had to ALLOW_CONNECTIONS to template0 to make it work
postgres=# 2018-02-27 21:29:05.993 +05 [57259] ERROR: Database template0 does not allow connections.
Is it a problem with my installation or some regression in the patch?

2018-02-27 21:40:47.132 +05 [57402] HINT: either disable or enable checksums by calling the pg_data_checksums_enable()/disable() functions
Function names are wrong in this hint: pg_enable_data_checksums()

The code is nice and clear. One minor spot in the comment
>This option can only _be_ enabled when data checksums are enabled.

Is there any way we could provide this functionality for previous versions (9.6,10)? Like implement utility for offline checksum enabling, without WAL-logging, surely.

Thanks for the patch!

Best regards, Andrey Borodin.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-02-27 17:00:23 Re: [HACKERS] GUC for cleanup indexes threshold.
Previous Message Tom Lane 2018-02-27 16:50:31 Re: prokind column (was Re: [HACKERS] SQL procedures)