Re: pgsql: injection_points: Remove portions related to custom pgstats

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> injection_points: Remove portions related to custom pgstats

BF member crake is unhappy with this, because it broke cross-version
update tests [1]:

pg_restore: while PROCESSING TOC:
pg_restore: from TOC entry 230; 1255 55098 FUNCTION injection_points_stats_drop() buildfarm
pg_restore: error: could not execute query: ERROR: could not find function "injection_points_stats_drop" in file "/home/andrew/bf/root/saves.crake/HEAD/lib/postgresql/injection_points.so"
Command was: CREATE FUNCTION "public"."injection_points_stats_drop"() RETURNS "void"
LANGUAGE "c" STRICT
AS '$libdir/injection_points', 'injection_points_stats_drop';

I think that this is really a bug in the Xversion-update test, because
I don't see why we'd be holding src/test/modules libraries to the
standard of can-be-upgraded-across-versions. But maybe there's
something I'm missing?

regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2025-12-08%2003%3A47%3A03&stg=xversion-upgrade-REL_18_STABLE-HEAD