Re: [Patch] RBTree iteration interface improvement

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] RBTree iteration interface improvement
Date: 2016-09-02 05:43:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 08/26/2016 04:07 PM, Aleksander Alekseev wrote:
>> Another unrelated change in this patch is the addition of
>> rb_rightmost(). It's not used for anything, so I'm not sure what the
>> point is. Then again, there don't seem to be any callers of
>> rb_leftmost() either.
> It's just something I needed in tests to reach a good percent of code
> coverage. Implementation of rb_rightmost is trivial so we probably can do
> without it.

Looking closer, we don't currently use any of the iterators besides the
left-right iterator either. Nor rb_delete().

>> I think we should something like in the attached patch. It seems to pass
>> your test suite, but I haven't done any other testing on this. Does it
>> look OK to you?
> Looks good to me.

Ok, committed.

- Heikki

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-09-02 06:04:31 Re: Forbid use of LF and CR characters in database and role names
Previous Message Ashutosh Bapat 2016-09-02 05:38:51 Re: Declarative partitioning - another take