| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Support partition pruning at execution time |
| Date: | 2018-04-09 22:03:02 |
| Message-ID: | 28986.1523311382@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I then noticed that support for nfiltered3 was incomplete; hence 0001.
> (I then noticed that nfiltered3 was added for MERGE. It looks wrong to
> me.)
In that case, it's likely to go away when Simon reverts MERGE. Suggest
you hold off committing until he's done so, as he probably already has
some conflicts to deal with and doesn't need another.
> Frankly, I don't like this. I would rather have an instrument->ntuples2
> rather than these "divide this by nloops, sometimes" schizoid counters.
> This is already being misused by ON CONFLICT (see "other_path" in
> show_modifytable_info). But it seems like a correct fix would require
> more code.
The question then becomes whether to put back nfiltered3, or to do
something more to your liking. Think I'd vote for the latter.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-04-10 02:59:43 | Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers. |
| Previous Message | Alvaro Herrera | 2018-04-09 21:58:51 | Re: pgsql: Support partition pruning at execution time |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-04-09 22:33:16 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |
| Previous Message | Alvaro Herrera | 2018-04-09 21:58:51 | Re: pgsql: Support partition pruning at execution time |