Re: CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?
Date: 2017-09-19 21:22:58
Message-ID: 2893.1505856178@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andreas Karlsson <andreas(at)proxel(dot)se> writes:
> Hm, I like the idea but I see some issues.

> Enforcing the BCP47 seems like a good thing to me. I do not see any
> reason to allow input with syntax errors. The issue though is that we do
> not want to break people's databases when they upgrade to PostgreSQL 11.
> What if they have specified the locale in the old non-ICU format or they
> have a bogus value and we then error out on pg_upgrade or pg_restore?

Well, if PG10 shipped with that restriction in place then it wouldn't
be an issue ;-)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-09-19 21:25:31 Re: Show backtrace when tap tests fail
Previous Message David G. Johnston 2017-09-19 21:21:25 Re: Re: issue: record or row variable cannot be part of multiple-item INTO list