Re: use of SPI by postgresImportForeignStatistics

I wrote:
> Rummaging in the gcc manual, it looks like you can turn on a warning
> for this with '-Wtraditional', but that also enables a boatload of
> warnings we don't want, so I can't see using it on a regular basis.

I experimented with that for fun. On current HEAD, it produces
347111 warnings, mostly "traditional C rejects ISO C style function
definitions". But amongst the dross there's

dbcommands.c:395:1: warning: non-static declaration of 'ScanSourceDatabasePgClassTuple' follows static declaration [-Wtraditional]
event_trigger.c:392:1: warning: non-static declaration of 'SetDatabaseHasLoginEventTriggers' follows static declaration [-Wtraditional]
tablecmds.c:20846:1: warning: non-static declaration of 'ConstraintImpliedByRelConstraint' follows static declaration [-Wtraditional]
nodeModifyTable.c:4154:1: warning: non-static declaration of 'ExecInitMerge' follows static declaration [-Wtraditional]
postmaster.c:4056:1: warning: non-static declaration of 'StartSysLogger' follows static declaration [-Wtraditional]
buf_table.c:48:1: warning: non-static declaration of 'BufTableShmemRequest' follows static declaration [-Wtraditional]
oracle_compat.c:555:1: warning: non-static declaration of 'dobyteatrim' follows static declaration [-Wtraditional]
pg_locale_icu.c:746:1: warning: non-static declaration of 'strncoll_icu_utf8' follows static declaration [-Wtraditional]
pg_locale_icu.c:767:1: warning: non-static declaration of 'strcoll_icu_utf8' follows static declaration [-Wtraditional]
pg_walsummary.c:230:1: warning: non-static declaration of 'walsummary_error_callback' follows static declaration [-Wtraditional]
pg_walsummary.c:245:1: warning: non-static declaration of 'walsummary_read_callback' follows static declaration [-Wtraditional]
vacuumdb.c:327:1: warning: non-static declaration of 'check_objfilter' follows static declaration [-Wtraditional]

if anyone cares to follow that up.

regards, tom lane