| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_waldump: support decoding of WAL inside tarfile |
| Date: | 2026-03-22 18:17:53 |
| Message-ID: | 2880042.1774203473@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> ... We can make this function far simpler
> and more obviously correct if we just accept that we'll read a
> WAL file completely before spilling it. See my proposed
> alternative to 0004, attached.
Actually, we can make that better yet by not expecting
get_archive_wal_entry to clean up after init_archive's
failure to free all irrelevant hashtable entries.
Better version attached.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0004-Fix-get_archive_wal_entry-to-handle-spilling-corr.patch | text/x-diff | 8.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-03-22 19:13:22 | Re: Add RISC-V Zbb popcount optimization |
| Previous Message | Lukas Fittl | 2026-03-22 18:13:11 | Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc? |