Re: [PATCH] Cleanup of GUC units code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-01 02:56:35
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Marko Kreen <markokr(at)gmail(dot)com> writes:
> - In attempt to preserve maximum range of values for INT64_IS_BUSTED
> systems, the code is written rather non-obvious way.

I do not personally object a bit to making the units comparisons
case-insensitive (I think it's mainly Peter who wants to be strict
about it). I don't think there are any other good ideas in this
patch, however, and exposing ourselves to intermediate overflows in
the name of simplicity is definitely not one.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Hitoshi Harada 2008-09-01 03:15:19 Re: Window functions patch v04 for the September commit fest
Previous Message Tom Lane 2008-09-01 02:44:50 Re: [PATCH] Make gram.y use palloc/pfree for memory management