| From: | Jacob Champion <jchampion(at)timescale(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Log details for client certificate failures |
| Date: | 2022-07-15 21:01:53 |
| Message-ID: | 2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/15/22 13:35, Andres Freund wrote:
>> (And do we want to fix it now, regardless?)
>
> Yes.
Cool. I can get on board with that.
>> What guarantees are we supposed to be making for log encoding?
>
> I don't know, but I don't think not caring at all is a good
> option. Particularly for unauthenticated data I'd say that escaping everything
> but printable ascii chars is a sensible approach.
It'll also be painful for anyone whose infrastructure isn't in a Latin
character set... Maybe that's worth the tradeoff for a v1.
Is there an acceptable approach that could centralize it, so we fix it
once and are done? E.g. a log_encoding GUC and either conversion or
escaping in send_message_to_server_log()?
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-15 21:06:51 | Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same transaction with other commands |
| Previous Message | Andres Freund | 2022-07-15 20:56:12 | Re: PG15 beta1 sort performance regression due to Generation context change |