Re: pgsql: RLS refactoring

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: RLS refactoring
Date: 2015-09-15 23:47:31
Message-ID: 28741.1442360851@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2015-09-15 19:16:06 -0400, Tom Lane wrote:
>> readfuncs.c doesn't actually stop to verify that the field name in stored
>> rules is what it expects.

> This reminds me: Is there a reason for that? ISTM that adding checks for
> the field names would make error messages about borked stored trees much
> easier to understand?

Dunno, how often have you seen such an error message, and how much would
it help anyway? I'm not sure it'd be worth the code and cycles to check.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-09-16 02:25:09 Re: [COMMITTERS] pgsql: Add --synchronous option to pg_receivexlog, for more reliable WA
Previous Message Andres Freund 2015-09-15 23:44:31 Re: pgsql: RLS refactoring

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2015-09-16 00:23:40 Re: src/test/ssl broken on HEAD
Previous Message Andres Freund 2015-09-15 23:44:31 Re: pgsql: RLS refactoring