| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: updated emacs configuration |
| Date: | 2014-06-09 14:52:34 |
| Message-ID: | 28740.1402325554@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Wed, Aug 07, 2013 at 07:57:53AM -0400, Peter Eisentraut wrote:
>> Did anyone have any outstanding concerns about this latest version? I
>> thought it looked ready to commit.
> After upgrading to GNU Emacs 23.4.1 from a version predating directory-local
> variables, I saw switch/case indentation go on the fritz. My hooks were
> issuing (c-set-style "postgresql"), but ".dir-locals.el" set it back to plain
> "bsd" style. The most-reasonable fix I found was to locally add c-file-style
> to ignored-local-variables.
It seems pretty ugly for this patch to be overriding our own
.dir-locals.el, especially in a way with as many potential side effects
as that. Why can't we fix .dir-locals.el to play nice with this?
Is there a way for it to check for whether postgresql style is defined?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2014-06-09 14:55:23 | Re: performance regression in 9.2/9.3 |
| Previous Message | Linos | 2014-06-09 14:51:38 | Re: performance regression in 9.2/9.3 |