| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jan Urbański <wulczer(at)wulczer(dot)org> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state |
| Date: | 2011-01-26 23:40:51 |
| Message-ID: | 28673.1296085251@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
=?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= <wulczer(at)wulczer(dot)org> writes:
> _2 is only Python 2.2, but I tried: with Python 2.2 there's a whole lot
> of regression tests that fail. The last release of 2.2 is April 2003,
> maybe it's time to forget about that particular dinosaur?
Well, there's little point in carrying an incorrect expected-file, so
unless someone is prepared to test the case regularly, I'd agree with
deleting that file. We could just add a note that the expected outputs
are intended for 2.3 and up and you'll get some error-message-wording
discrepancies with older python versions. The differences between _2
and _3 seem small enough for people to handle by visual inspection if
they really want to test the case.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-27 00:34:38 | pgsql: Change inv_truncate() to not repeat its systable_getnext_ordered |
| Previous Message | Peter Eisentraut | 2011-01-26 23:35:17 | pgsql: Use -Wformat-security when available |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Urbański | 2011-01-26 23:41:51 | Re: REVIEW: PL/Python table functions |
| Previous Message | Peter Eisentraut | 2011-01-26 23:40:43 | Re: pl/python refactoring |