| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Track LLVM 15 changes. |
| Date: | 2025-12-29 15:12:37 |
| Message-ID: | 2864710.1767021157@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Fri, Dec 26, 2025 at 6:05 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Surely we don't need this anymore? I tried removing it locally
>> and didn't see any such warnings (with Red Hat's llvm 20.1.8).
> Yeah. We should just delete these obsolete lines in 18 and master.
> For older branches, I think it should be enough to update the comment
> in 14-17, as attached.
LGTM.
> We could work harder and suppress the warnings
> only for LLVM 14 and 15 specifically in PostgreSQL 14-17, but it seems
> like the main point is surely to have *something* watching out for new
> warnings that are added in future LLVM versions, and we'll get that
> from the newer branches.
Agreed, not worth the trouble.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-12-29 18:01:39 | pgsql: Further stabilize a postgres_fdw test case. |
| Previous Message | Thomas Munro | 2025-12-29 09:15:57 | Re: pgsql: Track LLVM 15 changes. |