Re: How to update unicode mapping table?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Japin Li <japinli(at)hotmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: How to update unicode mapping table?
Date: 2023-09-25 22:20:10
Message-ID: 286457.1695680410@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 25.09.23 08:02, Japin Li wrote:
>> When I try to update the unicode mapping table through *.xml in
>> src/backend/utils/mb/Unicode/, it doesn't update the *.map files.
>> I find the make cannot go to this directory, what can I do to update
>> the mapping tables?

> This is done by "make update-unicode".

On a slightly related note, I noticed while preparing 3aff1d3fd
that src/backend/utils/mb/Unicode/Makefile seems a little screwy.
If you go into that directory and type "make distclean", you'll
find it removes some files that are in git:

[postgres(at)sss1 Unicode]$ make distclean
rm -f 8859-10.TXT 8859-13.TXT 8859-14.TXT 8859-15.TXT 8859-16.TXT 8859-2.TXT 8859-3.TXT 8859-4.TXT 8859-5.TXT 8859-6.TXT 8859-7.TXT 8859-8.TXT 8859-9.TXT BIG5.TXT CNS11643.TXT CP1250.TXT CP1251.TXT CP1252.TXT CP1253.TXT CP1254.TXT CP1255.TXT CP1256.TXT CP1257.TXT CP1258.TXT CP866.TXT CP874.TXT CP932.TXT CP936.TXT CP950.TXT JIS0212.TXT JOHAB.TXT KOI8-R.TXT KOI8-U.TXT KSX1001.TXT euc-jis-2004-std.txt gb-18030-2000.xml sjis-0213-2004-std.txt windows-949-2000.xml
[postgres(at)sss1 Unicode]$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
deleted: euc-jis-2004-std.txt
deleted: gb-18030-2000.xml
deleted: sjis-0213-2004-std.txt

no changes added to commit (use "git add" and/or "git commit -a")

This seems wrong. If you "make maintainer-clean", that removes even more:

$ git status
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
deleted: big5_to_utf8.map
deleted: euc-jis-2004-std.txt
deleted: euc_cn_to_utf8.map
deleted: euc_jis_2004_to_utf8.map
deleted: euc_jp_to_utf8.map
deleted: euc_kr_to_utf8.map
deleted: euc_tw_to_utf8.map
deleted: gb-18030-2000.xml
deleted: gb18030_to_utf8.map
deleted: gbk_to_utf8.map
deleted: iso8859_10_to_utf8.map
deleted: iso8859_13_to_utf8.map
deleted: iso8859_14_to_utf8.map
deleted: iso8859_15_to_utf8.map
deleted: iso8859_16_to_utf8.map
deleted: iso8859_2_to_utf8.map
deleted: iso8859_3_to_utf8.map
deleted: iso8859_4_to_utf8.map
deleted: iso8859_5_to_utf8.map
deleted: iso8859_6_to_utf8.map
deleted: iso8859_7_to_utf8.map
deleted: iso8859_8_to_utf8.map
deleted: iso8859_9_to_utf8.map
deleted: johab_to_utf8.map
deleted: koi8r_to_utf8.map
deleted: koi8u_to_utf8.map
deleted: shift_jis_2004_to_utf8.map
deleted: sjis-0213-2004-std.txt
deleted: sjis_to_utf8.map
deleted: uhc_to_utf8.map
deleted: utf8_to_big5.map
deleted: utf8_to_euc_cn.map
deleted: utf8_to_euc_jis_2004.map
deleted: utf8_to_euc_jp.map
deleted: utf8_to_euc_kr.map
deleted: utf8_to_euc_tw.map
deleted: utf8_to_gb18030.map
deleted: utf8_to_gbk.map
deleted: utf8_to_iso8859_10.map
deleted: utf8_to_iso8859_13.map
deleted: utf8_to_iso8859_14.map
deleted: utf8_to_iso8859_15.map
deleted: utf8_to_iso8859_16.map
deleted: utf8_to_iso8859_2.map
deleted: utf8_to_iso8859_3.map
deleted: utf8_to_iso8859_4.map
deleted: utf8_to_iso8859_5.map
deleted: utf8_to_iso8859_6.map
deleted: utf8_to_iso8859_7.map
deleted: utf8_to_iso8859_8.map
deleted: utf8_to_iso8859_9.map
deleted: utf8_to_johab.map
deleted: utf8_to_koi8r.map
deleted: utf8_to_koi8u.map
deleted: utf8_to_shift_jis_2004.map
deleted: utf8_to_sjis.map
deleted: utf8_to_uhc.map
deleted: utf8_to_win1250.map
deleted: utf8_to_win1251.map
deleted: utf8_to_win1252.map
deleted: utf8_to_win1253.map
deleted: utf8_to_win1254.map
deleted: utf8_to_win1255.map
deleted: utf8_to_win1256.map
deleted: utf8_to_win1257.map
deleted: utf8_to_win1258.map
deleted: utf8_to_win866.map
deleted: utf8_to_win874.map
deleted: win1250_to_utf8.map
deleted: win1251_to_utf8.map
deleted: win1252_to_utf8.map
deleted: win1253_to_utf8.map
deleted: win1254_to_utf8.map
deleted: win1255_to_utf8.map
deleted: win1256_to_utf8.map
deleted: win1257_to_utf8.map
deleted: win1258_to_utf8.map
deleted: win866_to_utf8.map
deleted: win874_to_utf8.map

no changes added to commit (use "git add" and/or "git commit -a")

To undo the mess, I tried "make", which did rebuild all those files
but now I have

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
(use "git add <file>..." to include in what will be committed)
8859-10.TXT
8859-13.TXT
8859-14.TXT
8859-15.TXT
8859-16.TXT
8859-2.TXT
8859-3.TXT
8859-4.TXT
8859-5.TXT
8859-6.TXT
8859-7.TXT
8859-8.TXT
8859-9.TXT
BIG5.TXT
CNS11643.TXT
CP1250.TXT
CP1251.TXT
CP1252.TXT
CP1253.TXT
CP1254.TXT
CP1255.TXT
CP1256.TXT
CP1257.TXT
CP1258.TXT
CP866.TXT
CP874.TXT
CP932.TXT
CP936.TXT
CP950.TXT
JIS0212.TXT
JOHAB.TXT
KOI8-R.TXT
KOI8-U.TXT
KSX1001.TXT
windows-949-2000.xml

nothing added to commit but untracked files present (use "git add" to track)

So there doesn't seem to be any clean way to regenerate the fileset
present in git. Maybe these targets aren't supposed to be invoked
here, but then why have a Makefile here at all? Alternatively,
maybe we have files in git that shouldn't be there (very likely due
to the fact that this directory also lacks a .gitignore file).

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-09-25 22:20:47 Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Previous Message Nathan Bossart 2023-09-25 22:09:45 Re: SET ROLE documentation improvement