Re: pgsql: Move gramparse.h to src/backend/parser

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Naylor <john(dot)naylor(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
Date: 2022-09-14 19:37:06
Message-ID: 2862807.1663184226@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

John Naylor <john(dot)naylor(at)postgresql(dot)org> writes:
> Move gramparse.h to src/backend/parser

The cfbot is unhappy since this commit; some but not all tests fail with

[09:33:13.793] In file included from scan.c:39:
[09:33:13.793] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.794] #include "gram.h"
[09:33:13.794] ^~~~~~~~
[09:33:13.839] In file included from parser.c:25:
[09:33:13.839] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.839] #include "gram.h"
[09:33:13.839] ^~~~~~~~

What I think is happening is that it was a mistake to remove
parser/gram.h from the dependencies of backend/Makefile's
generated-headers target: that allows builds to proceed before
gram.h has necessarily been created. The fact that it works
at all for anybody says that there's another dependency path
somewhere that causes bison to get run ... but, seemingly,
that doesn't always happen soon enough in a parallel build.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-09-14 19:56:13 pgsql: Update .gitignore
Previous Message Tom Lane 2022-09-14 18:45:10 pgsql: Use SIGNAL_ARGS consistently to declare signal handlers.