Re: miniscule compiler barf in pg_ctl.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Dann Corbit" <DCorbit(at)connx(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: miniscule compiler barf in pg_ctl.c
Date: 2004-07-22 01:46:14
Message-ID: 28619.1090460774@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Dann Corbit" <DCorbit(at)connx(dot)com> writes:
> default:
> ; /* <<<<<<<<<< Just a semicolon added here <<<<<<<<<<<< */
> /* assert(false); */
> }

Personally I prefer writing

default:
break;

Switch branches that don't have break or return at the end are trouble
waiting to happen, compiler glitches or no ...

Patched, thanks!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2004-07-22 01:50:31 Re: Why we really need timelines *now* in PITR
Previous Message Tom Lane 2004-07-22 01:42:00 Re: Missing header in zic.c?