From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: pg_tablespace_databases |
Date: | 2004-07-06 13:19:24 |
Message-ID: | 28599.1089119964@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> [ shrug... ] The name is not going to change again. I have never cared
>> for the practice of writing strlen("foo") as if it were a compile-time
>> constant.
> I think with gcc strlen("foo") is a compile-time constant.
Portability is exactly the root of the problem. If you are in the habit
of doing this then you get led into unportable behaviors like
char localarray[strlen(foo) + 1];
which no compiler except gcc will take. (We just had to fix exactly
that mistake in someone's patch within the last week or two.)
> What do you prefer?
I use "3" ;-). As long as the size calculation and the filling of the
string are immediately adjacent, the purpose of the code is clear
enough.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-07-06 14:20:28 | Re: [PATCH] s_lock support for win32 |
Previous Message | Gavin Sherry | 2004-07-06 12:44:55 | Re: pg_tablespace_databases |