Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi
Date: 2012-11-14 23:15:30
Message-ID: 28536.1352934930@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Wed, Nov 14, 2012 at 05:39:29PM -0500, Tom Lane wrote:
>> You would have been better off keeping the array and sorting it so you
>> could use binary search, instead of passing the problem off to the
>> filesystem.

> Well, testing showed using open() was a big win.

... on the filesystem you tested on. I'm concerned that it might not
look so good on other platforms.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2012-11-14 23:28:41 Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi
Previous Message Bruce Momjian 2012-11-14 22:58:14 Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2012-11-14 23:24:17 Re: Enabling Checksums
Previous Message Bruce Momjian 2012-11-14 22:58:14 Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi