Re: dblink versus long connection strings

Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes:
> On Tue, Nov 23, 2010 at 01:27, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm inclined to think that we should just change all the
>> truncate_identifier calls to warn=false, and forget about providing
>> identifier-truncated warnings here. It's too difficult to tell whether
>> a string is really meant as an identifier.

> It is not a truncated identifier, but I think the truncation is still
> worth warning because we cannot distinguish two connections that
> differ only >63 bytes.

The problem is to not give a warning when the string isn't meant as a
connection name at all, but as a libpq conninfo string (which can
perfectly reasonably run to more than 63 characters). Most if not all
of the dblink functions will accept either.

Perhaps a reasonable compromise is to issue the truncation warnings when
an overlength name is being *entered* into the connection table, but not
for simple lookups.

regards, tom lane