| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andreas Seltenreich <seltenreich(at)gmx(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] Parallel worker crash on seqscan |
| Date: | 2016-11-21 18:25:34 |
| Message-ID: | 28497.1479752734@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Nov 21, 2016 at 1:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Hah: not where I thought it was at all. The problem seems to be down to
>> the optimization I put into is_parallel_safe() awhile back to skip testing
>> anything if we previously found the entire querytree to be parallel-safe.
>> Well, the raw query tree *is* parallel-safe. It's only when we inject
>> some Params that we have a parallel hazard. So that optimization is too
>> optimistic :-(
> That sucks. Any idea how we might salvage it?
I just disabled it by checking to see if any Params have been created.
It might be possible to be more refined, but I dunno that adding more
bookkeeping would pay for itself.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2016-11-21 18:29:36 | Re: delta relations in AFTER triggers |
| Previous Message | Robert Haas | 2016-11-21 18:17:17 | Re: Patch to implement pg_current_logfile() function |