Re: [PATCH] pgbench tap tests fail if the path contains a perl special character

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Raúl Marín Rodríguez <rmrodriguez(at)carto(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: 2019-01-18 17:35:49
Message-ID: 28495.1547832949@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez(at)carto(dot)com> writes:
> As mentioned in the subject, if the $PATH where you are building postgres
> contains a perl's special character [1], for example a `+`, pgbench's tap
> tests will fail.

Fun. But is that really the only place that fails?

> I'm attaching a patch to fix this by using quotemeta [3].

This does not look right to me: glob has a different set of special
characters than regexes, no?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Raúl Marín Rodríguez 2019-01-18 17:54:07 Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Previous Message Raúl Marín Rodríguez 2019-01-18 17:15:46 [PATCH] pgbench tap tests fail if the path contains a perl special character