Re: libpq build problem with <io.h> on MS VC++

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Andrew Francis <locust(at)familyhealth(dot)com(dot)au>, pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: libpq build problem with <io.h> on MS VC++
Date: 2004-08-17 03:21:12
Message-ID: 28493.1092712872@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> OK, I have improved your comment and applied the patch. I mentioned the
> problem is only on MS C, but we might as well include io.h there on all
> Win32 platforms.

I am actually fairly uncomfortable with this solution. We learned the
hard way awhile back that we want to include postgres.h or siblings
*before* any system header file, because the system header files may
default to things we do not want otherwise. (Typical examples have to
do with 32-bit vs 64-bit file offsets.) Perhaps it will be okay to
violate that rule on this one specific file on this one specific
platform, but I would not bet on it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-08-17 03:52:45 Re: libpq build problem with <io.h> on MS VC++
Previous Message Bruce Momjian 2004-08-17 02:51:09 Re: GUC variables invisible to contrib/ modules

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-08-17 03:52:45 Re: libpq build problem with <io.h> on MS VC++
Previous Message Bruce Momjian 2004-08-17 02:51:09 Re: GUC variables invisible to contrib/ modules