Re: initdb failure in CVS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: initdb failure in CVS
Date: 2004-05-06 14:28:56
Message-ID: 28418.1083853736@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
> OTOH, I wonder if maybe what we previously did w.r.t. TZ didn't work, but
> the timezone libs were smart enough to disregard an empty TZ value.

The code in variable.c clearly does *not* work on machines where
putenv() copies what you hand it :-(. I suspect that no one noticed
because the clear_tz path isn't really used in normal situations.

I left it alone for the moment because I expect that we'll be ripping
it all out as soon as the dust settles with src/timezone. We can define
a less brain-dead API for testing validity of a timezone name ...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-05-06 14:32:21 Re: Is there any method to keep table in memory at startup
Previous Message Andrew Dunstan 2004-05-06 14:28:30 Re: Is there any method to keep table in memory at startup