Re: postgres_fdw: using TABLESAMPLE to collect remote sample

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: James Finnerty <jfinnert(at)amazon(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: postgres_fdw: using TABLESAMPLE to collect remote sample
Date: 2023-01-05 21:56:55
Message-ID: 2837327.1672955815@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
> There are no callers outside postgresAcquireSampleRowsFunc, so what
> about renaming them like this?

> deparseAnalyzeTuplesSql
> -> deparseAnalyzeInfoSql

> postgresCountTuplesForForeignTable
> -> postgresGetAnalyzeInfoForForeignTable

WFM.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-05 23:02:31 Re: Logical replication - schema change not invalidating the relation cache
Previous Message Matthias van de Meent 2023-01-05 21:49:23 Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE