| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES) |
| Date: | 2020-05-11 04:47:58 |
| Message-ID: | 28351.1589172478@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2020-May-06, Alvaro Herrera wrote:
>> This doesn't allow whitespace between "fall" and "through", which means
>> we generate 217 such warnings currently. Or we can just use
>> -Wimplicit-fallthrough=3, which does allow whitespace (among other
>> detritus).
> If we're OK with patching all those places, I volunteer to do so. Any
> objections? Or I can keep it at level 3, which can be done with minimal
> patching.
If we're gonna do it at all, I think we should go for the level 4
warnings. Level 3's idea of a fallthrough comment is too liberal
for my tastes...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2020-05-11 11:29:02 | Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES) |
| Previous Message | Alvaro Herrera | 2020-05-11 03:59:25 | Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-11 04:56:37 | Re: gcov coverage data not full with immediate stop |
| Previous Message | Kyotaro Horiguchi | 2020-05-11 04:38:57 | Re: 2020-05-14 Press Release Draft |