Re: small makeVar refactoring

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: small makeVar refactoring
Date: 2010-08-21 21:49:10
Message-ID: 28305.1282427350@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> While hacking around, I noticed that a lot of makeVar() calls could be
> refactored into some convenience functions, to save some redundancy and
> so that the unusual call patterns stand out better. Useful?

I'm not real thrilled with importing catalog/pg_attribute.h into
makefuncs.h; that seems like a lot of namespace pollution for not much
return. So -1 to makeVarFromAttribute. The other is okay although I'm
not convinced it's useful enough to bother with.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2010-08-21 22:28:34 pg_archivecleanup debug message consistency
Previous Message Peter Eisentraut 2010-08-21 21:13:23 small makeVar refactoring