| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use. |
| Date: | 2008-11-24 16:26:04 |
| Message-ID: | 2830.1227543964@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Hiroshi Inoue wrote:
>> because Shift_JIS isn't allowed as a server encoding. So
>> the Japanese Windows native message encoding Shift_JIS never
>> matches the server encoding EUC_JP and a conversion between
>> Shitt_jis and EUC_JP is necessarily needed.
> Ah, so we're basically hardcoding that information? The system will go
> up in SJIS, but since we can't deal with it, we switch it to EUC_JP?
I'm not following this either. If the patch is really necessary then it
seems it must be working around a bug in the Windows version of gettext,
ie failure to distinguish CP932 from CP20932. Is that correct?
> Ok, I think I understand. I've made some minor stylistic changes (we
> don't normally use if (NULL != <whatever>) in the pg sources), and will
> apply with those.
It definitely needs a comment explaining why this is needed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-11-24 19:19:46 | pgsql: Disable FNM_CASEFOLD. |
| Previous Message | Tom Lane | 2008-11-24 15:11:25 | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2008-11-24 17:00:02 | Re: blatantly a bug in the documentation |
| Previous Message | Gregory Stark | 2008-11-24 16:23:42 | Re: Visibility map, partial vacuums |