| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | 夏侯莯昍 <xiahoumuxuan(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Keep git-external-diff usage text from executing |
| Date: | 2026-10-22 20:33:07 |
| Message-ID: | 2829454.1792701187@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> writes:
> On Oct 21, 2026, at 12:16, 夏侯莯昍 <xiahoumuxuan(at)gmail(dot)com> wrote:
>> src/tools/git-external-diff is a Bash script, but its usage text is enclosed
>> in the Perl POD markers =comment and =cut. Bash therefore tries to execute
>> the prose and the embedded git config/git diff examples on each invocation.
> Per PG News on May 27 2018 [1], not sure how many folks still use this tool:
Surely, the number of people who use it is exactly zero --- else we'd
have heard complaints before now. So I'm rather inclined to just
delete it instead of expending effort on fixing it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lucas Jeffrey | 2026-10-22 21:01:33 | Re: Re: [PATCH] Fix segmentation fault caused by reentrancy in RI_Fkey_cascade_del (ri_triggers.c) |
| Previous Message | Matheus Alcantara | 2026-10-22 19:43:13 | Re: Wrong results from a parameterized Append |