Re: pg_tablespace_location() error message

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_tablespace_location() error message
Date: 2012-04-10 21:43:12
Message-ID: 28127.1334094192@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> The new pg_tablespace_location() function added in PG 9.2 to remove the
> director location from pg_tablespace returns an odd error for '0', which
> is InvalidOID:

Well, it's the same "odd error" you'd get for any other bogus OID.

The way the function is coded, it has no need to look into pg_tablespace
as such, which is why you don't get something like "no such tablespace".
We could add such a lookup purely for error detection purposes, but I'm
not real sure I see the point.

> Is this OK? It handles NULL just fine:

That's a consequence of the function being marked strict; it has nothing
much to do with anything.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2012-04-10 22:07:19 Re: Patch: add timing of buffer I/O requests
Previous Message Tom Lane 2012-04-10 21:20:08 Re: invalid search_path complaints