Re: Review Report: propose to include 3 new functions into intarray and intagg

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Markus Wanner <markus(at)bluegap(dot)ch>
Cc: dmitry(at)koterov(dot)ru, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review Report: propose to include 3 new functions into intarray and intagg
Date: 2008-09-07 00:55:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Markus Wanner <markus(at)bluegap(dot)ch> writes:
> Submission review: we generally prefer having patches archived on our
> mailing lists, so please just send future patches or revisions of this
> patch to our lists (I prefer -hackers, but probably -patches is still
> the official one).

Please. But -patches is dead, please use -hackers.

> The documentation should go into a README file of the
> contrib module or some such.

No, it should go into the SGML docs, specifically doc/src/sgml/intarray.sgml
and intagg.sgml. We got rid of flat-text README documentation for
contrib in 8.3, and are not about to permit any backsliding.

> Summary: My general feeling is, that this patch should be applied after
> minor code style corrections. As a longer term goal I think intagg
> should be integrated into core, since it's very basic functionality.

Well, what should be integrated is generic (non-datatype-specific)
versions of this functionality, ie functions working on
anyarray/anyelement not just int4[]/int4. There was some discussion
about that a few days ago. I'm not really sure how painful it would be
to do; probably the generalization to non-fixed-width types would be the
trickiest part.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2008-09-07 02:03:57 Re: [PATCHES] TODO item: Implement Boyer-Moore searching (First time hacker)
Previous Message Bruce Momjian 2008-09-07 00:19:38 Re: [PATCH] "\ef <function>" in psql