Re: openssl valgrind failures on skink are due to openssl issue

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: openssl valgrind failures on skink are due to openssl issue
Date: 2019-06-18 23:25:12
Message-ID: 28074.1560900312@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> What we could do is add a suppression like:

> {
> broken-openssl-accesses-random
> Memcheck:Cond
> ...
> fun:pg_strong_random
> fun:InitProcessGlobals
> fun:PostmasterMain
> fun:main
> }

> (alternatively one suppression for each RAND_status, RAND_poll,
> RAND_bytes(), to avoid suppressing all of pg_strong_random itself)

> and then prevent spread of the uninitialized memory by adding a
> VALGRIND_MAKE_MEM_DEFINED(buf, len);
> after a successful RAND_bytes() call.

> I tested that that quiesces the problem locally. Probably not worth
> pushing something like that though?

Yeah, that seems awfully aggressive to be pushing to machines that
don't have the problem. Did you get any sense of how fast the
openssl fix is goinng to show up?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-06-18 23:30:33 Re: ANALYZE: ERROR: tuple already updated by self
Previous Message Justin Pryzby 2019-06-18 23:12:33 ANALYZE: ERROR: tuple already updated by self