Re: remove unnecessary table_open/close from makeArrayTypeName

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: remove unnecessary table_open/close from makeArrayTypeName
Date: 2019-12-18 22:22:06
Message-ID: 28036.1576707726@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Commit bc8036fc666a (12 years ago) seems to have introduced an
> unnecessary catalog heap_open/close in order to do syscache accesses.

Huh. Not sure how that got past me, but I agree it's bogus.

> I presume a preliminary version of the patch used sysscans or something.
> I don't think that's necessary, so this patch removes it.

+1, but please collapse up the whitespace too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2019-12-18 23:46:46 Re: Read Uncommitted
Previous Message Tom Lane 2019-12-18 22:17:05 Re: Read Uncommitted regression test coverage