| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgindent weirdness |
| Date: | 2011-04-20 16:04:16 |
| Message-ID: | 28016.1303315456@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Now having said that, there seems to be a pgindent bug here too, in that
>> it's throwing a space into
>>
>> Buffer
>> RelationGetBufferForTuple(Relation relation, Size len,
>> Buffer otherBuffer, int options,
>> struct BulkInsertStateData * bistate)
>>
>> Whether BulkInsertStateData is flagged as a typedef or not, surely it
>> ought to understand that "struct BulkInsertStateData" is a type name.
> Uh, I think we have this listed as a known bug at the top of the
> pgindent script:
Hm. I guess the third observation is that in the current state of the
code, there's no very good reason to be using "struct" in
RelationGetBufferForTuple's prototype anyway, since the typedef is
declared right above it. Maybe we should just change that and not
risk fooling with pgindent.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2011-04-20 16:12:00 | Re: pgbench \for or similar loop |
| Previous Message | Tom Lane | 2011-04-20 16:00:58 | Re: REINDEX vs broken HOT chains, redux |