| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby. |
| Date: | 2008-10-22 22:53:29 |
| Message-ID: | 28006.1224716009@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> My interest was really in maintaining ultra-correctness, while removing
> the need to WAL log subcommits for Hot Standby. I think I achieved that,
> almost, but if you see further optimizations that is good too.
I'm not focusing on performance here --- I'm focusing on whether I trust
the patch at all. I dislike blowing a hole that size in the sanity
checks in TransactionIdSetStatus. I note that the hole still isn't
big enough, since presumably you'd have to allow ABORTED=>SUB_COMMITTED
too. That means that out of the four state transitions that are
disallowed by the original coding of that Assert, you are now having to
consider two as legal. I don't like that, and I like even less that
it's not even trying to determine whether this is a replay-driven
change.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-10-23 00:24:51 | pgsql: When estimating without benefit of MCV lists (suggesting that one |
| Previous Message | Simon Riggs | 2008-10-22 21:48:10 | Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2008-10-22 22:57:19 | Re: minimal update |
| Previous Message | Alvaro Herrera | 2008-10-22 22:48:37 | Re: psql Feature request \set query |