| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Gunnar Morling <gunnar(dot)morling(at)googlemail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unexpected behavior when setting "idle_replication_slot_timeout" |
| Date: | 2025-07-08 16:42:00 |
| Message-ID: | 27bce143-4011-4e83-8b91-392c11d318c8@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2025/07/06 1:13, Tom Lane wrote:
> I wrote:
>> I'm kind of down on changing the unit, because it will *silently*
>> break configuration files where the value was set without a unit.
>
> Oh, wait a second. I just noticed that this variable is new in v18.
> So there won't be a compatibility issue as long as we change it in
> v18 too. So changing it to a base of seconds seems sufficient,
> and more in line with existing practice:
Yes!
It seems there are currently no clear objections to the patch that
changes the unit of idle_replication_slot_timeout to seconds.
If that's the case, I'm planning to commit it to both master and v18.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-07-08 16:51:56 | Re: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c) |
| Previous Message | Tom Lane | 2025-07-08 13:36:37 | Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL |