From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
Cc: | Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: idea: log_statement_sample_rate - bottom limit for sampling |
Date: | 2019-08-04 20:25:12 |
Message-ID: | 27954.1564950312@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> On Sun, Aug 04, 2019 at 03:16:12PM -0400, Tom Lane wrote:
>> Isn't the issue here the interaction between log_transaction_sample_rate
>> and log_min_duration_statement?
> No, that interaction only affects statement-level sampling.
OK, I was confusing the features.
> For transaction-level sampling we do the sampling independently of the
> statement duration, i.e. we when starting a transaction we determine
> whether the whole transaction will be sampled. It has nothing to do with
> the proposed log_statement_sample_limit.
So, to clarify: our plan is that a given statement will be logged
if any of these various partial-logging features says to do so?
(And the knock on HEAD's behavior is exactly that it breaks that
independence for log_min_duration_statement.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2019-08-04 20:48:48 | Re: idea: log_statement_sample_rate - bottom limit for sampling |
Previous Message | Tomas Vondra | 2019-08-04 19:58:23 | Re: idea: log_statement_sample_rate - bottom limit for sampling |