Re: [PATCH v4] Add \warn to psql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH v4] Add \warn to psql
Date: 2019-07-05 16:38:02
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I wrote:
> David Fetter <david(at)fetter(dot)org> writes:
>> [ v7-0001-Add-warn-to-psql.patch ]

> I took a look at this. I have no quibble with the proposed feature,
> and the implementation is certainly simple enough. But I'm unconvinced
> about the proposed test scaffolding.

I pushed this with the simplified test methodology.

While I was fooling with it I noticed that the existing code for -n
is buggy. The documentation says clearly that only the first
argument is a candidate to be -n:

If the first argument is an unquoted <literal>-n</literal> the trailing
newline is not written.

but the actual implementation allows any argument to be recognized as

regression=# \echo this -n should not be -n like this
this should not be like thisregression=#

I fixed that, but I'm wondering if we should back-patch that fix
or leave the back branches alone.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Raúl Marín Rodríguez 2019-07-05 16:38:37 Re: Fix runtime errors from -fsanitize=undefined
Previous Message David Fetter 2019-07-05 16:32:04 SHOW CREATE