From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Brent Verner <brent(at)rcfile(dot)org>
Cc:
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,Douglas Trainor <trainor(at)uic(dot)edu>, pgsql-bugs(at)postgresql(dot)org,pgsql-patches(at)postgresql(dot)org
Subject:
Re: [PATCHES] COPY when 'filename' is a directory
Date:
2002-02-24 02:11:03
Message-ID:
27929.1014516663@sss.pgh.pa.us (view raw , whole thread or download thread mbox )
Thread:
2002-01-16 23:47:46 from Douglas Trainor <trainor(at)uic(dot)edu>
2002-01-17 12:08:10 from Brent Verner <brent(at)rcfile(dot)org>
2002-01-17 12:28:45 from Brent Verner <brent(at)rcfile(dot)org>
2002-01-25 02:04:55 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2002-02-23 02:10:18 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2002-02-23 21:45:45 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2002-02-24 01:27:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2002-02-24 01:56:22 from Brent Verner <brent(at)rcfile(dot)org>
2002-02-24 02:11:03 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2002-02-24 02:31:35 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2002-02-24 02:41:28 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2002-02-24 02:47:44 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2002-02-24 03:19:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2002-02-24 01:59:42 from Brent Verner <brent(at)rcfile(dot)org>
2002-02-24 02:03:35 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Lists:
pgsql-bugs pgsql-patches
Brent Verner <brent(at)rcfile(dot)org> writes:
> | This coding is WRONG. You do not use fclose() to release a file
> | opened with AllocateFile.
> s/fclose/FreeFile/
Actually, my recommendation is to remove it altogether. The mechanisms
are in place to close allocated files after elog(), so why waste thought
and code space to release them manually?
regards, tom lane
In response to
Responses
pgsql-bugs by date
Next :From: Bruce MomjianDate: 2002-02-24 02:31:35Subject : Re: [PATCHES] COPY when 'filename' is a directoryPrevious :From : Bruce MomjianDate : 2002-02-24 02:03:35Subject : Re: [PATCHES] COPY when 'filename' is a directory
pgsql-patches by date
Next :From: Bruce MomjianDate: 2002-02-24 02:31:35Subject : Re: [PATCHES] COPY when 'filename' is a directoryPrevious :From : Bruce MomjianDate : 2002-02-24 02:03:35Subject : Re: [PATCHES] COPY when 'filename' is a directory
