| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Brent Verner <brent(at)rcfile(dot)org> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Douglas Trainor <trainor(at)uic(dot)edu>, pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] COPY when 'filename' is a directory |
| Date: | 2002-02-24 02:11:03 |
| Message-ID: | 27929.1014516663@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
Brent Verner <brent(at)rcfile(dot)org> writes:
> | This coding is WRONG. You do not use fclose() to release a file
> | opened with AllocateFile.
> s/fclose/FreeFile/
Actually, my recommendation is to remove it altogether. The mechanisms
are in place to close allocated files after elog(), so why waste thought
and code space to release them manually?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-02-24 02:31:35 | Re: [PATCHES] COPY when 'filename' is a directory |
| Previous Message | Bruce Momjian | 2002-02-24 02:03:35 | Re: [PATCHES] COPY when 'filename' is a directory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-02-24 02:31:35 | Re: [PATCHES] COPY when 'filename' is a directory |
| Previous Message | Bruce Momjian | 2002-02-24 02:03:35 | Re: [PATCHES] COPY when 'filename' is a directory |