Re: errno clobbering in reorderbuffer

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: errno clobbering in reorderbuffer
Date: 2016-08-18 22:17:25
Message-ID: 27916.1471558645@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> While researching a customer issue with BDR I noticed that one ereport()
> call happens after clobbering errno, leading to the wrong strerror being
> reported. This patch fixes it by saving before calling
> CloseTransientFile and restoring afterwards.

> I also threw in a missing errcode I noticed while looking for similar
> problems in the same file.

Looks sane to me.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-08-18 22:18:52 Re: errno clobbering in reorderbuffer
Previous Message Andres Freund 2016-08-18 22:12:00 Re: errno clobbering in reorderbuffer