Garbled comment in postgresGetForeignJoinPaths

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Garbled comment in postgresGetForeignJoinPaths
Date: 2017-08-16 16:31:14
Message-ID: 27897.1502901074@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

postgres_fdw.c around line 4500:

/*
* If there is a possibility that EvalPlanQual will be executed, we need
* to be able to reconstruct the row using scans of the base relations.
* GetExistingLocalJoinPath will find a suitable path for this purpose in
* the path list of the joinrel, if one exists. We must be careful to
* call it before adding any ForeignPath, since the ForeignPath might
* dominate the only suitable local path available. We also do it before
--> * reconstruct the row for EvalPlanQual(). Find an alternative local path
* calling foreign_join_ok(), since that function updates fpinfo and marks
* it as pushable if the join is found to be pushable.
*/

Should the marked line simply be deleted? If not, what correction is
appropriate?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-08-16 16:38:21 Re: Hash Functions
Previous Message Peter Eisentraut 2017-08-16 16:24:11 Re: Function to move the position of a replication slot