Re: pgsql: Silence some Coverity warnings and improve code consistency.

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 11.04.21 23:02, Tom Lane wrote:
>> ... or more accurately, with an LL constant, which is not project
>> style. Make all of these use INT64CONST(), as we do elsewhere.

> I think this style could be considered obsolete because C99 requires LL
> constants, and configure checks for it.

I'm not worried about whether compilers will take LL --- after all, we
also make free use of "long long" these days. I am worried that
it does not necessarily equate to int64 exactly.

In any case, I'm not a fan of TIMTOWTDI. If we want to remove
[U]INT64CONST in favor of [U]LL, we should do so across the board,
so as to maintain a consistent project style.

regards, tom lane